Ability to distinguish connect timeouts and read timeouts

[kevinburkeshyp]

This request times out because the connect socket call fails:

var request = require('request');
request.get('http://google.com:81', {timeout: 3000}, function(err, response, body) {
    console.log(err.code === 'ETIMEDOUT');
    process.exit(0);
});

This request times out because the read socket call doesn't see any response in 3 seconds:

var request = require('request');
request.get('http://localhost:5501', {timeout: 3000}, function(err, response, body) {
    console.log(err.code === 'ETIMEDOUT');
    process.exit(1);
})

(I'm using hamms in the second test)

It would be nice to be able to distinguish these. Particularly, requests to a third party provider are failing and it would be good to distinguish whether the request actually made it to their server (their problem) or not (our problem).

It would also be neat because you could figure out whether or not the request made it to the server - a connection timeout is always retry-able, a read timeout on a POST is not.

[matteocontrini]

Up

[simov]

Fixed in #1711