Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tough cookie requirement for cookie jar #1740

Closed
nathanhleung opened this issue Aug 20, 2015 · 1 comment
Closed

Tough cookie requirement for cookie jar #1740

nathanhleung opened this issue Aug 20, 2015 · 1 comment

Comments

@nathanhleung
Copy link

For a basic implementation of cookies, it doesn't seem as if tough-cookie is necessary. My authentication is still preserved if I create a new request in the callback of a post request in which I authenticate. To activate cookies, all I had to do was write request = require('request').defaults({jar: true}).

The README.md mentions that tough-cookie is required, so if an update to request rendered it obsolete or something it would be helpful if the README was updated too.

Was request updated? Or am I implementing request in a non-traditional way?

@LoicMahieu
Copy link
Member

I merged PR #884 but it was a mistake. tough-cookie is builtin and required by request for a while. There is no need for user to install it manually. So I revert the PR in #1750. Sorry for confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants