Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-Type header shoudn't be set on GET #1786

Closed
thecadams opened this issue Sep 24, 2015 · 2 comments
Closed

Content-Type header shoudn't be set on GET #1786

thecadams opened this issue Sep 24, 2015 · 2 comments

Comments

@thecadams
Copy link

5225289 always sets Conent-Type for requests with json:true but this shouldn't happen for GET requests.

It's breaking our servers that see the Content-Type header and blindly go looking for a body.

We can work around it by downgrading but wanted to call your attention to it.
thecadams referenced this issue Sep 24, 2015
@jzaefferer
Set default application/json content-type when using json option
5225289 
Will set the header when using `json: true` without a body.
@simov
Copy link
Member

simov commented Sep 24, 2015

Fixed in #1785 I'll release it tomorrow.

@simov simov mentioned this issue Sep 24, 2015
Merged
@thecadams
Copy link
Author

Super fast turnaround - cheers!

@snyk-bot snyk-bot mentioned this issue Mar 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 1 vulnerabilities postmanlabs/postman-request
2 participants
@simov @thecadams