incorrect header check when deal with deflate content encoding

[goorockey]

var rq = require('request');
rq.get('https://web.wechat.com', {gzip: true});

Error: incorrect header check
    at Zlib._handle.onerror (zlib.js:370:17)

While the response from https://web.wechat.com is in deflate format, it show this error.
According to PR #2172, request library support deflate content encoding.

After I change responseContent = zlib.createInflate() to responseContent = zlib.createInflateRaw() in request.js, it work fine.

[simov]

That's interesting, it looks like our implementation is too optimistic. The only possible solution that I can think of is to peek into the stream and check if the zlib headers are present, then switch to either createInflate or createInflateRaw.

[windbender]

FWIW I found this precise error when trying to use tar.gz to decompress a x.tar.gz file created on an OS X machine

octogon:tmp lumigrow$ targz e ver1.tar.gz .
/usr/local/lib/node_modules/tar.gz/bin/targz:18
        throw err;
        ^
Error: incorrect header check
    at Zlib._handle.onerror (zlib.js:370:17)

The file is attached

ver1.tar.gz

[adampash]

Fwiw, I was running into the same error, and the @czardoz branch fixed it for me. (Thanks @czardoz!)

[umutm]

We also experience the same issue for some websites. Is there a planned official fix for that?

[gotojmp]

waiting for fix.

[mfrye]

I came across this on something unrelated, but @czardoz has a legit fix. It seems like that code should be apart of zlib right? To auto detect instances like that.

[thesadabc]

waiting for fix

[ali-habibzadeh]

waiting for fix

[mweathers]

waiting for fix

[rogierslag]

I'd also love a fix for this. http://www.mars.com/uk/en/careers/graduates-students/our-programmes/european-finance-development-programme is encountering the same problem

[goddkiller]

another method to avoid this problem is to set Accept-Encoding: gzip.
tell the server that you only use gzip.

[jiangts]

Why isn't the @czardoz branch getting submitted as a PR for merging?

[czardoz]

@jiangts Thanks for opening up a PR. I didn't get around to pushing my changes upstream.

[dreamalligator]

looks like this issue is still happening? I think via my jsdom dependency that requires request.