Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in 'time' documentation #2587

Closed
tomrf opened this issue Mar 7, 2017 · 6 comments
Closed

Inconsistency in 'time' documentation #2587

tomrf opened this issue Mar 7, 2017 · 6 comments
Labels

Comments

@tomrf
Copy link

tomrf commented Mar 7, 2017

Running request v2.80.0 with "time: true", the timing members do not match those in the documentation.

According to the documentation, there should be a 'timingPhases' object, this does not exist.

The 'timings' object contains { socket, connect, response, end, dns, tcp, firstByte, download, total } which is a mixture of what the documentation details between the 'timings' and 'timingPhases' objects.

Why am I seeing this inconsistency between documented objects and actual returned objects in my project?

@FredKSchott
Copy link
Contributor

@nicjansma any ideas?

@nicjansma
Copy link
Contributor

@tomrf @FredKSchott The timingPhases object was added in v2.81.0 via #2566

@pmanthen
Copy link

I still don't see timings or timingPhases in v2.81.0

@pmanthen
Copy link

My bad- my project was actually using 2.75.0. I see timingPhases in 2.81.0

@stale
Copy link

stale bot commented Nov 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Nov 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 23, 2019
@stale stale bot closed this as completed Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants