Replace hawk dependency with a local implemenation #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Sounds good to me. /cc @mikeal |
|
Thanks! When will this be published? |
|
I've published v2.87 with the patch. |
This was referenced Jul 4, 2018
2 tasks
kunagpal
added a commit
to postmanlabs/postman-request
that referenced
this pull request
Jul 9, 2018
* master: Update test certificates 2.87.1 Update changelog 2.87.0 Replace hawk dependency with a local implemenation (request#2943)
gene1wood
added a commit
to gene1wood/auth0-custom-lock
that referenced
this pull request
Jan 18, 2019
…nerability Dev dependencies contain `gulp-sass` which depends on `node-sass` `node-sass` [`4.9.3` requires `request` `2.87.0`](sass/node-sass#2435) [`request` `2.87.0` removes dependency on `hawk`](request/request#2943) `hawk` depends on `cryptiles` `cryptiles` has the vulnerability https://nvd.nist.gov/vuln/detail/CVE-2018-1000620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2831.
This replaces the hawk dependency with a local implementation that's identical.
This is the bare minimum the request community can do to disconnect this module from the hawk and hapi modules. The request community has been a major source of headache due to its inclusion of hawk and hoek. Because the maintainers have refused to remove this functionality, I am trying a simpler approach by moving the 100 lines of code from hawk here.
I will maintain this code if needed in the future which is better than you are getting today as I am no longer maintaining hawk v6 and this module cannot use v7 due to node requirements.