New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retry on ECONNREST broken #3131
Labels
Comments
This was referenced Sep 26, 2019
starkwang
pushed a commit
to nodejs/node
that referenced
this issue
Oct 12, 2019
Set ClientRequest.reusedSocket property when reusing socket for request, so user can handle retry base on wether the request is reusing a socket. Refs: request/request#3131 PR-URL: #29715 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
Since nodejs/node/pull/29715 is landed, this issue could be fixed. |
targos
pushed a commit
to nodejs/node
that referenced
this issue
Jan 8, 2020
Set ClientRequest.reusedSocket property when reusing socket for request, so user can handle retry base on wether the request is reusing a socket. Refs: request/request#3131 PR-URL: #29715 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
BethGriggs
pushed a commit
to nodejs/node
that referenced
this issue
Feb 6, 2020
Set ClientRequest.reusedSocket property when reusing socket for request, so user can handle retry base on wether the request is reusing a socket. Refs: request/request#3131 PR-URL: #29715 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
I found ECONNRESET is handled by retry in this PR #148 , but since forever agent is only used in Nodejs v0.xx, it's not working currently.
Simplest Example to Reproduce
Expected Behavior
No error.
Current Behavior
Encounter an error if wait 10~20 seconds.
Possible Solution
Maybe make req as resued in http_agent, or create a wrapper for default agent.
Context
Your Environment
The text was updated successfully, but these errors were encountered: