Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented tough-cookie installation. #884

Merged
merged 1 commit into from Jul 10, 2014

Conversation

wbyoung
Copy link
Contributor

@wbyoung wbyoung commented Apr 29, 2014

I was a little confused about using cookie jars. I got it working, but am not sure if this is the correct way or not. For me, in order for it to work, though-cookie needs to be installed. If this is how it's supposed to be, this pull request updates the docs to point that out.

LoicMahieu added a commit that referenced this pull request Jul 10, 2014
Documented tough-cookie installation.
@LoicMahieu LoicMahieu merged commit 47c001f into request:master Jul 10, 2014
nylen pushed a commit to nylen/request that referenced this pull request Oct 17, 2014
@LoicMahieu
Copy link
Member

I merged this PR but it was a mistake. tough-cookie is builtin and required by request for a while. There is no need for user to install it manually. So I revert the PR. Sorry for confusion.

LoicMahieu added a commit to LoicMahieu/request that referenced this pull request Aug 29, 2015
LoicMahieu added a commit that referenced this pull request Aug 29, 2015
Revert doc about installation of tough-cookie added in #884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants