Improve documentation for pool and maxSockets options

[nylen]

This has come up several times recently, for example #1150 and #1249.

[anklos]

Thanks!

I wonder is there any reason not use request.defaults() to change the actual request module?

I am asking this because I use unirest which depends on request. If I want to set maxSockets for unirest, I have to add request into package.json, make sure request is the same version used in unirest, then do unirest.request = require('request').defaults({pool:{maxSockets:100}}), rather than just do unirest.request.defaults({pool:{maxSockets:100}}).

[simov]

@anklos why don't you just use

var special = unirest.request.defaults({pool:{maxSockets:100}});

it should be the same

[nylen]

Modifying global defaults is very bad.

I'm not familiar with unirest, but how about unirest.request = unirest.request.defaults({ ... })?

[anklos]

@simov special is still request, I cannot call unirest functions on sepcial.

@nylen OK. I dont think I can do that as unirest does Unirest.request = require('request'); (https://github.com/Mashape/unirest-nodejs/blob/master/index.js#L787)
I may just submit a PR to unirest for setting maxSockets properly using defaults.

Thanks gents!

[nylen]

@anklos I still think my code above will work.

[anklos]

@nylen It works if I use request functions. As I am using unirest to do http calls, how I would make use of special?

[nylen]

unirest.request = unirest.request.defaults({ ... });

[anklos]

@nylen sorry confused by the other comment.

And my bad, you are right, that code should work. Thanks a lot!

[nylen]

You're welcome. Haven't seen any objections to this change, so merging.