Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds streams example for review #1269

Merged
merged 1 commit into from Nov 15, 2014
Merged

adds streams example for review #1269

merged 1 commit into from Nov 15, 2014

Conversation

tbuchok
Copy link
Contributor

@tbuchok tbuchok commented Nov 15, 2014

for review:

  • does this make enough sense for the common use case?
  • is my code style annoying enough here that we should get a common pattern?
  • what'd i miss or do wrong?

@tbuchok tbuchok mentioned this pull request Nov 15, 2014
Closed
@nylen
Copy link
Member

nylen commented Nov 15, 2014

Looks good to me, thanks for writing this up! I still think that examples should live in separate files and should mostly be runnable on their own, but I'm fine with taking that on myself in the future.

nylen added a commit that referenced this pull request Nov 15, 2014
@nylen
Merge pull request #1269 from tbuchok/post-stream-example
da34535 
adds streams example for review
@nylen nylen merged commit da34535 into request:master Nov 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbuchok @nylen