Enable non-object JSON bodies

[apoco]

Updated JSON requests so they can contain bodies that are not objects

[simov]

I wouldn't mind if we have t.deepEqual(value, body) here just to make sure (and clear) we're parsing back the value correctly. Currently that's not possible because createPostValidator is returning plain text, and in the case of this test it's checking only for the presence of the content-type header and if the value was stringified correctly.

[apoco]

I have updated the test to do this verification using a new createPostJSONValidator method that returns a JSON response.

[lalitkapoor]

Please see #1281 for more comments regarding this pull request.

[apoco]

@simov: updated the test

[simov]

@apoco can you pull simov@9634268 into your branch?

The changes are:

1. On the server you are asserting for proper stringify done by request + existing of headers
2. The deep equality check is in the request callback - you are asserting for proper parse done by request (not by the server)

The server returns the value as it is, you was returning object all the time, which does not test the changes you made.

Otherwise 👍 from me

[simov]

Actually you are implementing only the sending of non {} and [] stringified JSON bodies, but I though it's a good idea to test out the response parsing for them as well.

[apoco]

I rebased and pushed a change so that the test server returns the same body it received in the request as the response. I'm confused how this makes any difference, but I think this is what was asked for.

I'm confused because the prior test:

1. Verifies that request sent a JSON content type.
2. Verifies that the sent JSON represents the expected value; this is done by converting the JSON to a value with JSON.parse and using deep equality to ensure the values are equivalent.
3. Sends the value in a JSON response from the test server.
4. Verifies that request parses the JSON response from the server to a value (body).
5. Verifies that the value in the response is equivalent to the original value through deep equality.

To me, this describes what should be being tested. Am I missing something?

[simov]

Exactly, that's why in my last comment in the code I said that I'm ok with the deep equality check in the validator. The reason for returning the original value back to request is exactly the same as the deep equality check on the server. Practically this should be the same, of course, but just for the sake of completeness I though it's logical to have the same deep equality check for the client as well.

Anyway looking good to me, except that Travis is failing for some reason.

[apoco]

Gotcha. Looks like there was a timeout for a proxy test. It doesn't look related to my changes. Maybe there's a flaky test. Is there a way to re-run the tests? Or maybe that failure can be ignored.

[simov]

Yep, there is a restart build button, so I just did that - all passing.