fix(proxy): no-proxy false positive #1295
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one of the no-proxy item is exactly one character longer than the request URL, it was considered as a valid match for no-proxy case detection. This patch handle the special (-1) value.
|
👍 thanks! |
nylen
added a commit
that referenced
this pull request
Nov 28, 2014
fix(proxy): no-proxy false positive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the no-proxy item is exactly one character longer than the
request URL, it was considered as a valid match for no-proxy case
detection.
This patch handle the special (-1) value to close issue #1294.