Upgrade form-data, add back browserify compability. Fixes #455. #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We definitely want to support browserify. How do you propose to test this? |
nylen
added a commit
that referenced
this pull request
Dec 7, 2014
Upgrade form-data, add back browserify compability. Fixes #455.
|
I was thinking just adding a karma test run that tests a couple of requests. Right now I have a POC just requesting Just since animated gifs is worth more than a thousand words:
|
|
@eiriksm I think this would be really good to have! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The form-data module now has moved to a "browserifiable" mime module, so request can again be built with browserify if we upgrade to the latest version of form-data.
This PR fixes that.
Just wondering. If I make a PR where I add a test suite for making sure request can be used with browserify, will that be considered being added into request?