Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty buffer upon empty response body and encoding is set to null #1330

Merged
merged 1 commit into from Dec 31, 2014
Merged

Return empty buffer upon empty response body and encoding is set to null #1330

merged 1 commit into from Dec 31, 2014

Conversation

seanstrom
Copy link
Contributor

Instead of returning an empty string, an empty buffer will now be
returned when the encoding is set to null.

This is a PR to finish the work started #1286
Credit to @ramonsnir

@nylen @FredKSchott Review?

Instead of returning an empty string, an empty buffer will now be
returned when the encoding is set to null.
@nylen
Copy link
Member

nylen commented Dec 31, 2014

👍 thanks @seanstrom, and I learned about t.same today

nylen added a commit that referenced this pull request Dec 31, 2014
…ponse

Return empty buffer upon empty response body and encoding is set to null
@nylen nylen merged commit bd0aa25 into request:master Dec 31, 2014
@seanstrom seanstrom deleted the feature/empty-buffer-null-response branch December 31, 2014 22:27
@FredKSchott
Copy link
Contributor

👍 Yup looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants