Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always wait for server.close() callback in tests #1338

Merged
merged 1 commit into from Jan 8, 2015
Merged

Always wait for server.close() callback in tests #1338

merged 1 commit into from Jan 8, 2015

Conversation

nylen
Copy link
Member

@nylen nylen commented Jan 6, 2015

Somehow I missed a whole bunch of these in #1327. Maybe I was only searching for server.close() and not s.close()?

Ping @simov

@nylen
Always wait for server.close() callback in tests
6995181 
Somehow I missed a whole bunch of these in request#1327.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6995181 on nylen:server-close-async-2 into 3786137 on request:master.

nylen added a commit that referenced this pull request Jan 8, 2015
@nylen
Merge pull request #1338 from nylen/server-close-async-2
6abe25c 
Always wait for server.close() callback in tests
@nylen nylen merged commit 6abe25c into request:master Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nylen @coveralls