Rewrite tunnel test to be pure Node.js #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need this in a minute (because the hostname gets reset during tunneling)
The new test is doing much more than the old one was, and as far as I can tell, no one was ever running it.
|
👍 nice job |
|
I'm assuming your finished with this, I'll merge tomorrow end of today, unless you say otherwise. |
seanstrom
added a commit
that referenced
this pull request
Jan 25, 2015
Rewrite tunnel test to be pure Node.js
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test is doing much more than the old one was, and as far as I can tell, no one was ever running it since it required
squid.This will be nice to have when making further changes/fixes related to tunneling and proxies, such as #1344 and #1368.