Do not rfc3986 escape JSON bodies #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example {json:{}} or {body:{}, json:true}
Related to request#1315
Closes request#1395
|
The behavior looks correct. I tried to clean up the test a little to get comfortable that we're doing the right thing here, can you pull in nylen@29f98f3? |
| @@ -1428,15 +1428,15 @@ Request.prototype.json = function (val) { | |||
| if (self.body !== undefined) { | |||
| if (!/^application\/x-www-form-urlencoded\b/.test(self.getHeader('content-type'))) { | |||
| self.body = safeStringify(self.body) | |||
| } else { | |||
| self.body = rfc3986(self.body) | |||
There was a problem hiding this comment.
Can you swap this conditional around? Also, I see we have a test for it (body + header + json) but in what situation is this needed?
edit - I think I see - this allows parsing a JSON response without sending the body as JSON.
|
Done. Are we good with this one (regarding your comment from above)? |
nylen
added a commit
that referenced
this pull request
Feb 2, 2015
Do not rfc3986 escape JSON bodies
|
Yeah, thanks for taking a look! |
|
version |
This was referenced Feb 2, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
{json:{}}or{body:{}, json:true}Related to #1315
Closes #1395
Also take a look at the options section of the documentation.