Fixing tests to pass on io.js #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 but tests are now failing on node as well |
|
I think we should merge at least the passing test fixes into master cc @nicolasmccurdy the only failing test on node 0.12/iojs is the strict branch in test-https.js |
|
It's not fixed, I just merged master so that the work can continue here (the certificates were expired) Once the failing test is fixed we should fix the readme and the travis.yml |
@simov Agreed. |
simov
added a commit
that referenced
this pull request
Mar 5, 2015
Fixing tests to pass on io.js and node 0.12 (only test-https.js stiff failing)
|
Merged. Check your PRs from small merge conflicts (if any) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all the tests but test-https, which is so convoluted I'm having a hard time figuring out what is broken.