Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Node.js 0.12 and io.js with allowed failures #1453

Merged
merged 3 commits into from Mar 5, 2015

Conversation

nickmccurdy
Copy link
Contributor

This is based on #1415 by @demohi, except I configured Travis to allow failures on Node 0.12 and io.js. This way, contributors can work on bug fixes and see the test results in CI without breaking the build for Node 0.10.

@simov
Copy link
Member

simov commented Mar 2, 2015

This way, contributors can work on bug fixes and see the test results in CI

I can argue that anyone will ever see the failing tests (any of them) not only related to these ones currently failing on node 0.12 or io.js

The build says All is well with bold green, so unless I click on the Details I'll never know what's going on.

@nickmccurdy
Copy link
Contributor Author

That's a good point, though I only planned on allowing failures until the 0.12 and io.js tests pass (while the fixes are in development). And even with the allowed failures, the build will still fail if 0.10 fails.

Or, if the maintainers of the project are okay with this, we could test on 0.12 and io.js without allowed failures.

@simov
Copy link
Member

simov commented Mar 2, 2015

Isn't it better to have the failing status always? One additional click but that way you'll always check which one is passing. I just don't like the idea of silently passing on errors. Other than that I got the point and I agree that we should have 0.12 and iojs in the build script.

@nickmccurdy
Copy link
Contributor Author

That's a good point. Go ahead and merge your pull request if you'd like.

simov added a commit that referenced this pull request Mar 5, 2015
Test on Node.js 0.12 and io.js with allowed failures
@simov simov merged commit b84a5d2 into request:master Mar 5, 2015
@simov
Copy link
Member

simov commented Mar 5, 2015

I think that's a better solution for now, than not having io.js and node 0.12 in the build.

@nickmccurdy nickmccurdy deleted the travis-allowed-failures branch March 5, 2015 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants