New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable io.js/node 0.12 build #1468
Conversation
Fixed the issue with strictSSL tests on 0.12 & io.js by explicitly setting a cipher that matches the cert.
@@ -41,7 +41,7 @@ | |||
"isstream": "~0.1.1" | |||
}, | |||
"scripts": { | |||
"test": "npm run lint && node node_modules/.bin/taper tests/test-*.js && npm run test-browser && npm run clean", | |||
"test": "npm run lint && node node_modules/.bin/taper tests/test-*.js && npm run test-browser", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had a clean script back then, that logic was later moved to the browser test itself. NPM on node 0.10 doesn't complain about the missing script, where the newer version of it throws an error.
cc @eiriksm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it seems like this is safe to remove then. npm won't look anywhere else for scripts to run (see run).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think the clean script removed a browserified build of the test script, but the current version browserifies the test script on the fly instead.
👍 Nice job! |
Fixed the negative msecs error and re-enabled io.js and node 0.12 in the build.
Closes #1421
Closes #1414