Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for qs options via qsOptions key #1477

Merged
merged 2 commits into from Mar 21, 2015
Merged

Conversation

simov
Copy link
Member

@simov simov commented Mar 13, 2015

Closes #1473

The qsOptions key can be used to pass options to both the parse and the stringify methods of the qs and querystring modules.

The arrayFormat options was missing from the qs readme ljharb/qs#72

@simov simov mentioned this pull request Mar 16, 2015
@nylen
Copy link
Member

nylen commented Mar 16, 2015

A few thoughts on this:

  1. Can we link directly to the relevant options from the readme?
  2. Not our issue, but it's hard to tell from a glance what options the qs methods support.
  3. Since this does a lot of different things, may be better to split it into two: qsParseOptions and qsStringifyOptions?
  4. Some text like this might be good, too:

qsOptions - object containing options to pass to the qs or querystring module_, for example, to change the way arrays are converted to query strings_

@simov
Copy link
Member Author

simov commented Mar 17, 2015

Agreed, I was thinking about the same problem - different options for parse and stringify Also adding links there would be good.

@simov
Copy link
Member Author

simov commented Mar 18, 2015

Improved the docs a bit, and introduced the qsParseOptions and the qsStringifyOptions keys.

simov added a commit that referenced this pull request Mar 21, 2015
Add support for qs options via qsOptions key
@simov simov merged commit 0cfebc6 into request:master Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array parameters in the query string produce numeric indexes
2 participants