Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the forever agent #1486

Merged
merged 2 commits into from Mar 23, 2015
Merged

Add a test for the forever agent #1486

merged 2 commits into from Mar 23, 2015

Conversation

akshayp
Copy link
Contributor

@akshayp akshayp commented Mar 15, 2015

@nicolasmccurdy Adding a test for #1472. This passes on node 0.10 and fails on 0.12.x and iojs

Closes #1472

@nickmccurdy
Copy link
Contributor

👍

@FredKSchott
Copy link
Contributor

+1 This should probably be merged, even if it is breaking. Any objections @nylen @seanstrom @simov ?

@seanstrom
Copy link
Contributor

I agree we should take this, but we need to patch asap.
Im willing to take a look at this tonight/tomorrow.

@simov
Copy link
Member

simov commented Mar 20, 2015

@seanstrom that would be great. Although having this PR and the failing test is good, I don't think merging it without a fix is the right thing to do, as it may stay that way indefinitely.

@seanstrom
Copy link
Contributor

Okay good news, I got the tests to pass by patching ForeverAgent.
I'll have a PR for that up really soon.

@seanstrom
Copy link
Contributor

Here's the PR for the patch, request/forever-agent#25

@simov
Copy link
Member

simov commented Mar 22, 2015

@akshayp can you bump the forever-agent version to 0.6.0 and push so that we can see the tests passing.

@akshayp
Copy link
Contributor Author

akshayp commented Mar 23, 2015

@simov Pushed and tests are now all passing. Thanks for the patch @seanstrom!

simov added a commit that referenced this pull request Mar 23, 2015
Add a test for the forever agent
@simov simov merged commit ed6d53e into request:master Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forever-agent does not work with Node 0.12
5 participants