New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Archive 1.2 support #1501
HTTP Archive 1.2 support #1501
Conversation
Thanks @ahmadnassri ! Without being very familiar with HAR (or at all), I can say that your code looks great. 👍 from me for merging this PR. The next request release is scheduled for the upcoming week, so in the meantime I'll review your code again more thoroughly, just to familiarize myself with HAR. |
}, {}) | ||
} | ||
|
||
// construct Cookie heade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, should be header
Same here, thank you for contributing :) @simov I left some notes but I probably won't have time to do a more detailed code review. |
thanks for the notes @nylen, new commit coming right up. |
@simov you've inspired me to create this up-to-date collection of resources for HTTP Archive :) |
That's a really comprehensive list @ahmadnassri 👍 I'll merge your PR shortly, in case anyone else have something to add. btw you have one more broken anchor where you link back to the HAR section from the options. |
I've added Request to the list of HAR Resources cheers. |
passing a HAR Request 1.2 in
options.har
will construct and set matchingoptions
values for use in the request.this makes the library particularly useful when dealing with debug / performance data from many tools and proxies, especially to repeat requests from the browser's network panel.