Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow static invoking of convenience methods #1515

Merged
merged 1 commit into from Mar 29, 2015

Conversation

simov
Copy link
Member

@simov simov commented Mar 27, 2015

Fixes #1506

simov added a commit that referenced this pull request Mar 29, 2015
Allow static invoking of convenience methods
@simov simov merged commit 0ff7fc3 into request:master Mar 29, 2015
@simov simov mentioned this pull request Mar 29, 2015
@ghost
Copy link

ghost commented Mar 30, 2015

Can we get a release for this asap?

@simov
Copy link
Member Author

simov commented Mar 30, 2015

@kytwb we're rounding up a few more bugfixes and improvements, so until then you can use version 2.53 unless your code relies on features introduced in 2.54, in that case you can use the latest master in your package.json (not perfect)

"request": "git://github.com/request/request.git"

@ghost
Copy link

ghost commented Mar 30, 2015

@simov: Most of our projects build is now broken due to this regression, would rather wait for a release if it's coming soon than changing the package.json in all the projects to finally rollback when the fix is out. Let me know.

@simov
Copy link
Member Author

simov commented Mar 30, 2015

Ok, my assumption was that you have fixed dependency versions in your packages, which again my not be ideal but it's safer.

Anyway I understand that this bug is a problem for a lot of people, so it's better to have a new release soon. However there is one more bugfix submitted related to the same issue, then I'm going to make some improvements on that logic that caused the bugs. So we should wait a couple of days, probably till the end of the week.

@ghost
Copy link

ghost commented Mar 30, 2015

@simov: Fair enough, thanks for the prompt reply.

@simov
Copy link
Member Author

simov commented Apr 5, 2015

2.55 is published on NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined is not a function (functions must be bound by 'request').
2 participants