Fix defaults #1518
Merged
Fix defaults #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check should happen before invoking the custom requester function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1509
Introduced in #1429 #1430 follow up #1435
Related to this bug as well #1515
Calling a convenience method from default object wasn't using the defaults properties, because the method was not wrapped, and therefore the extend logic wasn't called at all.
Then I'm temporarily passing a string to the wrap function so that I can make the head-body check before calling the requester just to satisfy the https://github.com/request/request/blob/master/tests/test-defaults.js#L265 test.
I'm going to improve the entire defaults related logic in index.js after this PR got merged in, because it's extremely hard to follow and obviously too error prone.