Fix coveralls #1541
Merged
Fix coveralls #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow this test modifies the process state Test coverage runs all tests in a single process via tape Executing this test causes one of the tests in test-tunnel to throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 test fixes that was causing the coveralls build to fail (check out the comments).
Coveralls is now using the GitHub's status API to report the coverage status (instead of using comments) So this will make the merge status bar color change based on the coverage results, just like any other build error do. Decrease in coverage will be considered a warning. Click on the Show all checks button below.