Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update combined-stream #1560

Merged
merged 1 commit into from May 5, 2015
Merged

Update combined-stream #1560

merged 1 commit into from May 5, 2015

Conversation

mike-zorn
Copy link
Contributor

This updated combined-stream now uses an updated delayed-stream which no longer
uses the non-standard __defineGetter__ syntax. By removing this, request can
now be loaded in IE10+ (which doesn't support __defineGetter__).

@simov
Copy link
Member

simov commented May 5, 2015

Thanks 👍 what's the reason behind changing the version modifier? Can you change it back to ~?

This updated combined-stream now uses an updated delayed-stream which no longer
uses the non-standard `__defineGetter__` syntax. By removing this, request can
now be loaded in IE10.
@mike-zorn
Copy link
Contributor Author

@simov just changed it back to ~. I just did npm install --save 😜

simov added a commit that referenced this pull request May 5, 2015
@simov simov merged commit 8382742 into request:master May 5, 2015
@dgsunesen
Copy link

I still have this problem? Updated request to latest version? Am I missing something?

@dgsunesen
Copy link

It seems to be 'form-data' that has an older version of 'combined-stream' as a dependency.. version ~0.0.4 and that version of 'combined-stream' is dependant on an older version of 'delayed-stream'.. version 0.0.5 which have the non-standard __defineGetter__ syntax

@simov
Copy link
Member

simov commented Jun 10, 2015

Thanks for the heads up, @dgsunesen, I'm planning on dropping the form-data dependency at some point in favor of our home made multipart module, as form-data doesn't seems to be actively maintained.

But in the meantime, in case you are sure that bumping the stream version there fixes your problem, you can open up a PR there and hope it gets published on NPM any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants