Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1630
It turned out that when the body is set via the
.form()
method thecontent-length
is not being set, and therefore the request is sent astransfer-encoding:'chunked'
which may cause problems with some servers.So I refactored out the logic responsible for setting up the
content-length
:Much sexier than it was before, plus that conditional structure allows it to be called again inside the
defer
method. Now for the function name and declaration position it's just there for now, I couldn't figure out a better place to put it, but then again it's visible inside thedefer
function.Lastly the
test-form-urlencoded
tests now checks if thecontent-length
header is present as well.