debug() when JSON.parse() on a response body fails #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously JSON.parse() failures was silently ignored. Although `response.body` would still contain the invalid JSON response body as a string, instead of a JS object, it's valueable to know the JSON was invalid while debugging.
simov
added a commit
that referenced
this pull request
Jul 29, 2015
debug() when JSON.parse() on a response body fails
|
Yep, seems good. Emitting error there won't be good as there are plenty of consumers that handle this case by themselves already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously JSON.parse() failures was silently ignored.
Although
response.bodywould still contain the invalid JSON response body as a string, instead of a JS object, it's valueable to know the JSON was invalid while debugging.I was tempted to
.emit('error', new Error('Invalid JSON received'))but that might be a little harse.Any thoughts?