Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in README.md #1721

Merged
merged 1 commit into from Aug 18, 2015
Merged

Minor fix in README.md #1721

merged 1 commit into from Aug 18, 2015

Conversation

arbaaz
Copy link
Contributor

@arbaaz arbaaz commented Aug 9, 2015

uri is not defined.

uri is not defined.
@simov
Copy link
Member

simov commented Aug 18, 2015

Hi, @arbaaz. I honestly don't see what is this PR fixing. Feel free to elaborate.

@simov simov closed this Aug 18, 2015
@arbaaz
Copy link
Contributor Author

arbaaz commented Aug 18, 2015

When I used the same snippet in my code exception occurred('uri is not defined'). When I changed to url it started working.

@simov
Copy link
Member

simov commented Aug 18, 2015

Now I see it:

var url = 'http://www.google.com';

is defined in the code block above. Is that it?

@simov simov reopened this Aug 18, 2015
@arbaaz
Copy link
Contributor Author

arbaaz commented Aug 18, 2015

Yes. that is it.

simov added a commit that referenced this pull request Aug 18, 2015
@simov simov merged commit d0a9a6b into request:master Aug 18, 2015
@simov simov changed the title update README.md Minor fix in README.md Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants