New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query strings now cooperate with unix sockets #1767
Conversation
@@ -27,7 +31,12 @@ tape('setup', function(t) { | |||
}) | |||
|
|||
tape('unix socket connection', function(t) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to have two separate tests, the original one without querystring and a new one with querystring. That way if someone removes the unix bits from the init function the tests will throw an error.
Hey, @JoshWillik nice work on this one. I added a few comments. |
Also brings .enableUnixSocket calls in line with the rest of the code stylistically.
Query strings now cooperate with unix sockets
👍 |
:D Thanks @simov |
@simov How often does request update on NPM? I'd like to be able to stop doing my own query string assembly in my code 😛 |
Usually when someone asks about it, or when there is a bugfix that affects a lot of people. Strictly non semver :) but that'll change at some point. I'll let you know when the new release is published on NPM. |
@JoshWillik 2.62 is published. |
Hooray! Thank you :D On Tue, Sep 15, 2015 at 4:25 AM, simo notifications@github.com wrote:
|
Fixes #1766