Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query strings now cooperate with unix sockets #1767

Merged
merged 2 commits into from Sep 11, 2015

Conversation

JoshWillik
Copy link
Contributor

Fixes #1766

@@ -27,7 +31,12 @@ tape('setup', function(t) {
})

tape('unix socket connection', function(t) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to have two separate tests, the original one without querystring and a new one with querystring. That way if someone removes the unix bits from the init function the tests will throw an error.

@simov
Copy link
Member

simov commented Sep 11, 2015

Hey, @JoshWillik nice work on this one. I added a few comments.

Also brings .enableUnixSocket calls in line with the rest of
the code stylistically.
simov added a commit that referenced this pull request Sep 11, 2015
Query strings now cooperate with unix sockets
@simov simov merged commit 2bca671 into request:master Sep 11, 2015
@simov
Copy link
Member

simov commented Sep 11, 2015

👍

@JoshWillik
Copy link
Contributor Author

:D Thanks @simov

@JoshWillik JoshWillik deleted the sockets-with-querystrings branch September 13, 2015 19:59
@JoshWillik
Copy link
Contributor Author

@simov How often does request update on NPM? I'd like to be able to stop doing my own query string assembly in my code 😛

@simov
Copy link
Member

simov commented Sep 14, 2015

Usually when someone asks about it, or when there is a bugfix that affects a lot of people. Strictly non semver :) but that'll change at some point. I'll let you know when the new release is published on NPM.

@simov
Copy link
Member

simov commented Sep 15, 2015

@JoshWillik 2.62 is published.

@JoshWillik
Copy link
Contributor Author

Hooray! Thank you :D

On Tue, Sep 15, 2015 at 4:25 AM, simo notifications@github.com wrote:

@JoshWillik https://github.com/JoshWillik 2.62 is published.


Reply to this email directly or view it on GitHub
#1767 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants