Implement support for RFC 2617 MD5-sess algorithm. #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking good, thanks for the contribution @BigDSK 👍 |
|
@simov Good idea. I had missed the TODO list. Overall my understanding of RFC 2617 is that we now cover both options. If your understanding is that algorithm may be something other than "MD5" or "MD5-sess", then we should incorporate some type of error handling. Silently falling back to a default/incorrect algorithm was confusing in my case. I believe we're good to go though. |
Update TODO list Remove challenge.algorithm TODO note
BigDSK
force-pushed
the
enhance/support-rfc-2617-md5-sess
branch
from
1bc49f9
to
033e7fc
Compare
simov
added a commit
that referenced
this pull request
Oct 9, 2015
Implement support for RFC 2617 MD5-sess algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation does not handle the RFC 2617 MD5-sess algorithm. I've added that ability along with a simple test. I've also confirmed this is working against an IIS server ( the only real-world test I have at my disposal ).