Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated qs dependency to 5.2.0 #1828

Merged
merged 1 commit into from Oct 8, 2015
Merged

Updated qs dependency to 5.2.0 #1828

merged 1 commit into from Oct 8, 2015

Conversation

acroca
Copy link
Contributor

@acroca acroca commented Oct 7, 2015

One of the things included in 5.2.0 is a sort option to stringify query strings sorted.

@chenchaoyi
Copy link

#1827

@acroca acroca closed this Oct 7, 2015
@acroca acroca reopened this Oct 7, 2015
@simov
Copy link
Member

simov commented Oct 8, 2015

I'm a bit confused, why was #1827 closed? @mikeal ?

@boennemann
Copy link

@simov Short version: Greenkeeper bug that's fixed now
Long version: https://github.com/greenkeeperio/support/issues/11#issuecomment-146476824

Either way: Sorry, our bad 😓

simov added a commit that referenced this pull request Oct 8, 2015
Updated qs dependency to 5.2.0
@simov simov merged commit 56312b9 into request:master Oct 8, 2015
@simov
Copy link
Member

simov commented Oct 8, 2015

👍

@acroca
Copy link
Contributor Author

acroca commented Oct 9, 2015

@mikeal When do you think you'll do the next release?

@mikeal
Copy link
Member

mikeal commented Oct 9, 2015

if you want me to, today :)

@acroca
Copy link
Contributor Author

acroca commented Oct 9, 2015

:shipit:

@simov
Copy link
Member

simov commented Oct 9, 2015

Can we wait a little bit? We have two more PRs that I want in the new release.

@acroca
Copy link
Contributor Author

acroca commented Oct 9, 2015

Sure, I'll be pointing to master in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants