Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement loose matching for har mime types #1876

Merged
merged 2 commits into from Oct 30, 2015
Merged

Implement loose matching for har mime types #1876

merged 2 commits into from Oct 30, 2015

Conversation

simov
Copy link
Member

@simov simov commented Oct 29, 2015

Fixes #1872

@simov simov mentioned this pull request Oct 29, 2015
Closed
@sod
Copy link

sod commented Oct 29, 2015

Thank you for taking over the issue.

There is another switch/case in: https://github.com/request/request/pull/1876/files?w=1#diff-13c8aeb1b94f67f8c33c1cab8c4b1021R165

And maybe add a ; charset=UTF-8 to one of the mime types in https://github.com/request/request/blob/master/tests/fixtures/har.json and see if the tests pass :)

@simov
Copy link
Member Author

simov commented Oct 29, 2015

Yep, these are good suggestions. Pushed a fix.

simov added a commit that referenced this pull request Oct 30, 2015
@simov
Merge pull request #1876 from simov/fix-har-mime
30fcf67 
Implement loose matching for har mime types
@simov simov merged commit 30fcf67 into request:master Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simov @sod