Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tunneling after redirection from https (Original: #1881) #1894

Merged
merged 2 commits into from Nov 9, 2015
Merged

Fix tunneling after redirection from https (Original: #1881) #1894

merged 2 commits into from Nov 9, 2015

Conversation

falms
Copy link
Contributor

@falms falms commented Nov 7, 2015

Current stable module (request@2.65.0) cannot handle https-to-http redirection with proxy properly.

When redirected from https to http with options.tunnel = undefined,
the http request should be proxied without CONNECT tunneling.

This pull-request includes these changes:

  1. use initial options.tunnel again after redirection.
  2. fix test case for https-to-http redirection.
  3. fix description about tunnel option.

Closes #1881

simov added a commit that referenced this pull request Nov 9, 2015
…imple

Fix tunneling after redirection from https (Original: #1881)
@simov simov merged commit 973f0ee into request:master Nov 9, 2015
@simov
Copy link
Member

simov commented Nov 9, 2015

Thanks @falms 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants