Add AWS Signature Version 4 #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added aws-sign4 support added tests Added sign_version parameter doc fixed test fix changes removed changes on CHANGELOG fix fix fix comma
|
When this will be merged? |
|
I'm thinking about moving the require statement down below inside the aws handler and make aws4 external dependency. I don't feel comfortable adding more dependencies in request. Similar to how it's done in request/core. |
|
Ok feel free to apply your edits, you know what are a good stuff for the module |
|
2.68 is published 🎉 |
| , amazonHeaders: aws.canonicalizeHeaders(self.headers) | ||
|
|
||
| if (opts.sign_version == 4 || opts.sign_version == '4') { | ||
| var aws4 = require('aws4') |
There was a problem hiding this comment.
This dependency was only added as a devDependency. See #2040
rmg
added a commit
to rmg/request
that referenced
this pull request
Jan 27, 2016
It was moved in request#2036 as a devDependency, but is still used in request.js This should fix request#2040.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2031
https://www.npmjs.com/package/aws4)