restore aws4 as regular dependency #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was moved in request#2036 as a devDependency, but is still used in request.js This should fix request#2040.
This was referenced Jan 27, 2016
mikeal
added a commit
that referenced
this pull request
Jan 27, 2016
restore aws4 as regular dependency
|
released v2.69.0. |
|
@mikeal thanks, verified. 👍 |
|
Oh, wow, guess who's not using browserify .. also used during runtime and detected during parsing the file as a string are two completely different things. Point taken - never trust browserify :) Also I was thinking about adding it as peerDep but I wasn't sure about the warning, otherwise not installing it (if npm3 is used) is what I want. As for the optionalDep that's completely useless in my case because the dep is still being installed. |
|
we should never use peerDeps, they are a giant mistake :) |
|
Well installing them automatically is a mistake I agree. Warnings shouldn't break the build though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was moved in #2036 as a devDependency, but is still used in
request.js
This should fix #2040.