Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, here is some fixes that closes #2035 and #2044 and #2056
First off, one of the issues were that we are testing across 3 versions of npm. They have different behaviours when encountering peerDependencies. So ideally I would almost say we should upgrade npm to at least npm@2 for node 0.10. But open to opinions there. This was the least disruptive change, in my opinion.
Second, one of the issues were pointing out that the response object changed for one of the tests. So I ran the same test code with node, where the result was illuminating the fact that the browser test was testing for something only happening in the browser. So I changed that test, so it can check for a result that also is the same result when running on node.
Fixes #2035
Fixes #2044
Closes #2056