Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check error type instead of string #2349

Merged
merged 1 commit into from Aug 28, 2016
Merged

Conversation

scotttrinh
Copy link
Contributor

Upstream change broke this unit test. Fixed this in another PR and realized that it's probably better off as it's own PR.

form-data just released 1.0.0, and it changed the order of property lookup what triggers a TypeError when we push up a null form-data property. This change just checks that it throws a TypeError instead of checking the string.

Upstream code change link

Upstream change broke this unit test.
@simov simov merged commit 4d33333 into request:master Aug 28, 2016
@simov
Copy link
Member

simov commented Aug 28, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants