Migrating to safe-buffer for improved security. #2574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have run and passed locally but I'm curious to see what CI says because I haven't tested against older versions of Node.js yet.
I ended up having to push a quick release of
tunnel-agent
to cover this potential vulnerability fully. There are no tests fortunnel-agent
so that only way to get any coverage was to push a release and then pull that new release into this PR.