Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AWS SigV4 support. #2791

Merged
merged 1 commit into from Jul 16, 2018
Merged

Improve AWS SigV4 support. #2791

merged 1 commit into from Jul 16, 2018

Conversation

vikhyat
Copy link
Contributor

@vikhyat vikhyat commented Oct 11, 2017

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: N/A

PR Description

This makes the following changes to the AWS SigV4 signing functionality:

  1. Sign all request headers instead of just Content-Type.
  2. Allow specifying a service name.

This makes the following changes to the AWS SigV4 signing functionality:

1. Sign all request headers instead of just Content-Type.
2. Allow specifying a service name.
@chasingSublimity
Copy link

Any chance we could get this merged? If there's other work necessary, I'd be happy to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants