Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hawk to 7.0.7 #2880

Merged
merged 1 commit into from Mar 6, 2018
Merged

Update hawk to 7.0.7 #2880

merged 1 commit into from Mar 6, 2018

Conversation

kornel-kedzierski
Copy link
Contributor

@kornel-kedzierski kornel-kedzierski commented Feb 23, 2018

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

@mickhansen
Copy link

This was a breaking change in my case, the new version of hawk has a node engine of >= 8 and it's sntp dependency has async in the codebase.

We run code with request on lambda which doesn't go higher than 6.10 and we don't normally compile dependencies with babel (not sure if this is expected).

@desenmeng
Copy link
Contributor

@desenmeng
Copy link
Contributor

@mikeal

@Apollon77
Copy link

same problem here. Please revert that ASAP!!

@lchayoun
Copy link

+1

3 similar comments
@ezraroi
Copy link

ezraroi commented Mar 12, 2018

+1

@ezhukovskiy
Copy link

+1

@justinkjchang
Copy link

+1

@AlCalzone
Copy link

the new version of hawk has a node engine of >= 8 and it's sntp dependency has async in the codebase.

Well... this is bad.

@cschuff
Copy link

cschuff commented Mar 12, 2018

+1

1 similar comment
@timocov
Copy link

timocov commented Mar 12, 2018

+1

@Apollon77
Copy link

@simov

@alanquigley
Copy link

+1

@vladimir-tikhonov
Copy link

vladimir-tikhonov commented Mar 12, 2018

That's why you shouldn't ignore CI builds - https://travis-ci.org/request/request/jobs/345197366 :D

@ByronLian
Copy link

+1

1 similar comment
@yutackall
Copy link

+1

simov added a commit that referenced this pull request Mar 12, 2018
@Apollon77
Copy link

Apollon77 commented Mar 12, 2018

Interestingly travis-ci is still "red" also for the revert commit

@Karthi-R
Copy link

Finally found this! thanks for the quick fix.

@simov
Copy link
Member

simov commented Mar 12, 2018

More information about why this PR was reverted here: #2891 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet