Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mjs note for external lib users #861

Closed

Conversation

TristanCacqueray
Copy link

Copy link

vercel bot commented May 14, 2024

@TristanCacqueray is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@fhammerschmidt fhammerschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I suggested some slight changes

pages/docs/manual/latest/build-external-stdlib.mdx Outdated Show resolved Hide resolved
pages/docs/manual/latest/build-external-stdlib.mdx Outdated Show resolved Hide resolved
@TristanCacqueray
Copy link
Author

You're welcome!

@fhammerschmidt
Copy link
Collaborator

Sorry I will close this and adapt the page myself a bit more. This approach is not really a thing we want to recommend.

@TristanCacqueray TristanCacqueray deleted the patch-1 branch May 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@rescript/core package doesn't have the javascript file
2 participants