New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace xxxParams & xxxWithParams with *Options #591

Open

MoOx opened this issue Aug 28, 2019 · 3 comments

Member

MoOx commented Aug 28, 2019 •

edited

Following #577 (comment)

Collaborator

sgny commented Aug 28, 2019

I'm copying my comment as the PR is already merged.

What if instead of withOptions we used withOptional (or withOptionals)? Then we could have optional parameters or configs without causing much confusion.

Member Author

MoOx commented Aug 30, 2019

You see a problem with xxxWithOptions & xxxOptions because they look too similar?
If so I would go for xxxWithOptions & xxxMakeOptions

Collaborator

sgny commented Aug 31, 2019

Not that they are too similar, but most arguments are in the end options in a config. Most are required and rarely when we have optional arguments it might be clearer to label the additional function as WithOptional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment