Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plan to support JSX v4 #790

Open
pd4d10 opened this issue Jan 10, 2023 · 3 comments
Open

The plan to support JSX v4 #790

pd4d10 opened this issue Jan 10, 2023 · 3 comments

Comments

@pd4d10
Copy link

pd4d10 commented Jan 10, 2023

The problem

rescript@10.1.0 and @rescript/react@0.11.0 have supported JSX v4. Wondering if there is any plan about this.

Considered solution

Support JSX v4 and bump a major version.

Alternatives solutions

Stay at v3

@fhammerschmidt
Copy link
Contributor

It is supported already. Is there anything that does not work for you?

@pd4d10
Copy link
Author

pd4d10 commented Mar 29, 2023

Could you please give a brief example? V3 and v4 seems not to be compatible:

-"jsx": { "version": 3 },
+"jsx": { "version": 4 },

@fhammerschmidt
Copy link
Contributor

As long as you have the current version of rescript-react-native (0.70.0) installed, this change should just work. At work, we use it for quite some time now with JSX v4 (and automatic mode, but that should not matter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants