Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom in/out of devices on trackpad pinch gesture in the preview area #1049

Open
manojVivek opened this issue Aug 16, 2023 · 20 comments · May be fixed by #1196
Open

Zoom in/out of devices on trackpad pinch gesture in the preview area #1049

manojVivek opened this issue Aug 16, 2023 · 20 comments · May be fixed by #1196
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@manojVivek
Copy link
Collaborator

No description provided.

@manojVivek manojVivek added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 16, 2023
@prabhjotlamba1655
Copy link

Hi @manojVivek, I would like to work on this issue. Please assign it to me.

@manojVivek
Copy link
Collaborator Author

@prabhjotlamba1655 Please go ahead!

@dgbkn
Copy link

dgbkn commented Sep 14, 2023

HI @manojVivek i would like to take up this issue if possible.
Assign it to me.

@manojVivek
Copy link
Collaborator Author

@dgbkn Please go for it!
We stopped doing user assignments for the issues.

@Priyanshu72
Copy link

can you please elaborate this issue

@MarCUS103
Copy link

@manojVivek Could you please elaborate the issue? It will be very beneficial while resolving the issue.

@mukulpythondev
Copy link

I am start working on this issue.

@sameerbiradar2001
Copy link

Hi @manojVivek, I would like to work on this issue. Please assign it to me.

@Alok-Singh-ops
Copy link

@manojVivek we can not directly use zoom pan pinch lib here due to the fact that lib does not support webview tag. We need to write its logic manually.

@manojVivek
Copy link
Collaborator Author

@Alok-Singh-ops Thanks for exploring that.

But we don't actually need that event handler on the webview, we just have to add it to the preview area enclosing the webview.

@Alok-Singh-ops
Copy link

@manojVivek yes i get it. i Even tried to do using lib such as zoom pan but I guess the library just does not support webview

@manojVivek
Copy link
Collaborator Author

Hm, I'm not certain why webview would affect anything here.

As we don't need to interact with the webview at all in this, we just have to watch for the events on the preview container and update the zoom level in the redux state.

@Alok-Singh-ops
Copy link

@manojVivek Gotcha. By this entire preview section will be zoomed in/zoomed out

@Alok-Singh-ops
Copy link

@manojVivek Also, I have raised by PR kindly look into it

@manojVivek
Copy link
Collaborator Author

By this entire preview section will be zoomed in/zoomed out

Just clarifying, not the entire section, just the devices will be zoomed by the zoomFactor state value.

@dompolochak
Copy link

dompolochak commented Dec 4, 2023

From what I can tell there needs to be some sort of onWheel or onScroll event to trigger the zoomFactor update but it doesnt seem to respond to any of those events (also doesn't respond to onClick) I think something about the webview is preventing the div from detecting events
Edit: When I expand the div to be larger than the webview actions outside of the webview are detected so it is something about the webview not being able to detect the pinch to zoom
Screenshot 2023-12-04 at 2 59 37 PM

@123upasana
Copy link

Hi @manojVivek, I would like to work on this issue. Please assign it to me.

@lyncasterc
Copy link
Contributor

Hey @manojVivek, I went ahead and created a PR for this (#1196) since it looks like it hasn't been addressed yet!

@samr874
Copy link

samr874 commented Mar 9, 2024

@manojVivek explain me the functionality you are working on ?? which issue is this assign it to me

@brkuhgk
Copy link

brkuhgk commented Mar 22, 2024

Hello everyone, do we have any updates regarding this issue? If not, I'm more than willing to lend a hand and contribute. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.