Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8+ #69

Open
lon9man opened this issue Apr 26, 2023 · 5 comments
Open

PHP 8+ #69

lon9man opened this issue Apr 26, 2023 · 5 comments

Comments

@lon9man
Copy link

lon9man commented Apr 26, 2023

Hello, do you have plans to refactor code to upgrade it to PHP 8.1+?

as minimum function strftime is deprecated:
https://php.watch/versions/8.1/strftime-gmstrftime-deprecated

thanks!

@jonaz
Copy link

jonaz commented May 16, 2023

We have done it in this fork: https://github.com/FortnoxAB/php-resque

@liviocmachado
Copy link

@jonaz Thanks... with php 8.2 I get the error below, do you intend to loop one more for correction?

{"level":8192,"message":"Creation of dynamic property App\Models\Email::$args is deprecated","file":"/home/rm4/vendor/resque/php-resque/lib/Resque/Job/Factory.php","line":28}

@jonaz
Copy link

jonaz commented Aug 29, 2023

@jonaz Thanks... with php 8.2 I get the error below, do you intend to loop one more for correction?

{"level":8192,"message":"Creation of dynamic property App\Models\Email::$args is deprecated","file":"/home/rm4/vendor/resque/php-resque/lib/Resque/Job/Factory.php","line":28}

Are you running our fork?

@liviocmachado
Copy link

Yes @jonaz

@jonaz
Copy link

jonaz commented Aug 30, 2023

Yes @jonaz

Have you created the public args property on your Email class? Its not supported to do that dynamic anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants