From 03ae608189f3ecfd4b26f57853c9f5d838e453ea Mon Sep 17 00:00:00 2001 From: Norbert Bartels Date: Wed, 3 Feb 2021 21:29:57 +0100 Subject: [PATCH] Issue #1120 - message attachment convenience method added --- src/main/lombok/com/restfb/types/Message.java | 12 ++++++++++++ src/test/java/com/restfb/types/MessageTest.java | 11 +++++++++-- src/test/resources/json/v7_0/message-eu.json | 11 +++++++++++ 3 files changed, 32 insertions(+), 2 deletions(-) create mode 100644 src/test/resources/json/v7_0/message-eu.json diff --git a/src/main/lombok/com/restfb/types/Message.java b/src/main/lombok/com/restfb/types/Message.java index 07d8efc57..c03147416 100644 --- a/src/main/lombok/com/restfb/types/Message.java +++ b/src/main/lombok/com/restfb/types/Message.java @@ -227,6 +227,18 @@ public boolean isVideo() { return null != videoData; } + /** + * returns if the attachment is a placeholder for the real + * attachment, that is not accessible via API due to privacy rules in Europe + * + * check at Facebook + * + * @return true if not accessible in the EU + */ + public boolean isRemovedInEurope() { + return "1234".equals(getId()); + } + } /** diff --git a/src/test/java/com/restfb/types/MessageTest.java b/src/test/java/com/restfb/types/MessageTest.java index ca93068a2..c2b1f7c9a 100644 --- a/src/test/java/com/restfb/types/MessageTest.java +++ b/src/test/java/com/restfb/types/MessageTest.java @@ -22,8 +22,7 @@ package com.restfb.types; import static com.restfb.testutils.RestfbAssertions.assertThat; -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.*; import java.util.List; @@ -87,4 +86,12 @@ void messagesWithSticker() { assertNotNull(exampleMessage); assertEquals("https://scontent.xx.fbcdn.net/sticker.png", exampleMessage.getSticker()); } + + @Test + void messageWithRemovedAttachment() { + Message exampleMessage = createJsonMapper().toJavaObject(jsonFromClasspath("v7_0/message-eu"), Message.class); + assertNotNull(exampleMessage); + Message.Attachment attachment = exampleMessage.getAttachments().get(0); + assertTrue(attachment.isRemovedInEurope()); + } } diff --git a/src/test/resources/json/v7_0/message-eu.json b/src/test/resources/json/v7_0/message-eu.json new file mode 100644 index 000000000..a49294a3e --- /dev/null +++ b/src/test/resources/json/v7_0/message-eu.json @@ -0,0 +1,11 @@ +{ + "attachments": { + "data": [ + { + "id": "1234", + "name": "Media not available due to new privacy rules in Europe. See developer documentation for more info" + } + ] + }, + "id": "m_mid.12345678900:3911138c1ded9ef216" +} \ No newline at end of file