From 638aaf71fabda882e39fb748bea71aa96c5a277b Mon Sep 17 00:00:00 2001 From: Norbert Bartels Date: Sun, 15 Nov 2020 18:34:44 +0100 Subject: [PATCH] Issue #1103: mssing fields added and minor cleanup --- src/main/java/com/restfb/DefaultFacebookClient.java | 10 +++++++--- src/main/lombok/com/restfb/types/ads/AdCreative.java | 10 ++++++++++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/restfb/DefaultFacebookClient.java b/src/main/java/com/restfb/DefaultFacebookClient.java index 7ae1d4d22..79f938ab5 100644 --- a/src/main/java/com/restfb/DefaultFacebookClient.java +++ b/src/main/java/com/restfb/DefaultFacebookClient.java @@ -304,9 +304,7 @@ public T fetchObjects(List ids, Class objectType, Parameter... pa // Normalize the IDs for (String id : ids) { - if (StringUtils.isBlank(id)) { - throw new IllegalArgumentException("The list of IDs cannot contain blank strings."); - } + throwIAEonBlankId(id); idArray.add(id.trim()); } @@ -320,6 +318,12 @@ public T fetchObjects(List ids, Class objectType, Parameter... pa } } + private void throwIAEonBlankId(String id) { + if (StringUtils.isBlank(id)) { + throw new IllegalArgumentException("The list of IDs cannot contain blank strings."); + } + } + /** * @see com.restfb.FacebookClient#publish(java.lang.String, java.lang.Class, com.restfb.BinaryAttachment, * com.restfb.Parameter[]) diff --git a/src/main/lombok/com/restfb/types/ads/AdCreative.java b/src/main/lombok/com/restfb/types/ads/AdCreative.java index 55ec91c35..0487afaf6 100644 --- a/src/main/lombok/com/restfb/types/ads/AdCreative.java +++ b/src/main/lombok/com/restfb/types/ads/AdCreative.java @@ -225,6 +225,11 @@ public class AdCreative extends NamedAdsObject { @Facebook("instagram_story_id") private String instagramStoryId; + @Getter + @Setter + @Facebook("instagram_user_id") + private String instagramUserId; + @Getter @Setter @Facebook("interactive_components_spec") @@ -367,6 +372,11 @@ public class AdCreative extends NamedAdsObject { @Facebook("product_set_id") private String productSetId; + @Getter + @Setter + @Facebook("source_instagram_media_id") + private String sourceInstagramMediaId; + /** * The run status of this creative. *