Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultFacebookExceptionGenerator.skipResponseStatusExceptionParsing is too sloppy #1088

Closed
DerKeil opened this issue Aug 25, 2020 · 1 comment
Assignees
Milestone

Comments

@DerKeil
Copy link

DerKeil commented Aug 25, 2020

Hey,
the criterion used in DefaultFacebookExceptionGenerator.skipResponseStatusExceptionParsing() is too sloppy, as there is an example of a successful API-request that will be converted into a FacebookGraphException, instead of the correct reply being returned.

Example:
The request
https://graph.facebook.com/v3.1/debug_token?input_token=abcd&access_token=efgh
can give the correct reply

{
   "data": {
      "type": "PAGE",
      "error": {
         "code": 190,
         "message": "Page does not exist or cannot be loaded"
      },
      "expires_at": 0,
      "is_valid": false,
      "issued_at": 1597649209,
      "profile_id": "123...",
      "scopes": [
         
      ]
   }
}

which is then not returned as a DebugTokenInfo, but converted into a FacebookGraphException.

@nbartels
Copy link
Contributor

Okay, let me check this ...

@nbartels nbartels self-assigned this Aug 25, 2020
@nbartels nbartels added this to the 3.10.0 milestone Aug 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants